Re: [PATCH] generic/079: remove assignment of the test to acl and attr groups

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Jul 13, 2020 at 03:26:48PM +0300, Vladimir Zapolskiy wrote:
> The test does not belong to acl group of tests, and expectedly the test
> is supposed to pass on a filesystem which supports file attributes but
> not ACLs.
> 
> In addition the test should be removed from attr group of tests, because
> the attr group specifies tests which operate over extended file attributes,
> this test does not fall into this category.
> 
> The change is intended to improve the assignment of tests to groups
> to get better testing coverage, if a list of run tests is selected by
> test group attributes.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir@xxxxxxxxxx>

Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

--D

> ---
>  tests/generic/group | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/group b/tests/generic/group
> index d9ab9a31f2ed..3d7effe6d72a 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -81,7 +81,7 @@
>  076 metadata rw udf auto quick stress
>  077 acl attr auto enospc
>  078 auto quick metadata
> -079 acl attr ioctl metadata auto quick
> +079 auto quick ioctl metadata
>  080 auto quick
>  081 auto quick
>  082 auto quick quota
> -- 
> 2.25.1
> 



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux