On Wed, Jul 08, 2020 at 10:15:18AM +0200, Lukas Czerner wrote: > On Wed, Jul 08, 2020 at 03:35:13PM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Frequently when trying to reproduce a problem I want to run a set of > > specific tests in a loop, over and over again. I run fstests from a > > set of run scripts that have non-trivial overhead (e.g. patterning > > block devices before the runs start), so if all I want to do is run > > the same test 100x, using a shell loop over the entire run > > scripts reduces the iteration rate substantially. > > > > Hence add an option to check to allow fstests to loop a number of > > times over the configured test set without stopping. > > Hi Dave, > > this is useful as I am often doing the same. However what I am really > missing is the ability to end the loop when a test fails and the ability > to run tests in infinite loop (or until the test fails). To run until a test set fails, I have just been using "-i 10000" because if it passes 10000 loops, it isn't going to fail.. :) Hence I didn't see a need to complicate things with a specific "loop forever" options. > It should be easy modification to make, what do you think ? Feel free to add send a patch on top of this one to support that - all of the failures I've been looking at with this have been "test does not complete" failures, so it wasn't important to me. As it is, right now I don't have time to feature creep simple modifications like this into more complex functionality - I really only sent this out because Willy mentioned on #xfs that he wished there was a way to loop a test and I said "I've got a patch on my local tree for that".... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
