Re: [PATCH v2] xfs: add test for CVE-2020-12655

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



Hi Darrick,

On Tue, Jun 23, 2020 at 08:23:52AM -0700, Darrick J. Wong wrote:

...

> > +
> > +	_scratch_unmount > /dev/null 2>&1
> > +	[ $mounted -eq 0 -o $hasmsg -eq 1 ] && return
> > +	_fail "potential broken kernel"
> 
> Could you print both variables in the error message so that it's easier
> to figure out where exactly we went wrong?

Okay, will fix in the next version (tomorrow, about to sleep...)

> 

...

> >  518 auto quick quota
> >  519 auto quick reflink
> > +520 auto quick reflink dangerous
> 
> Hmmm... I guess the fix has been out for a while, so it's less shocking
> to put a dangerous test in the auto group?

Okay, will update it (I'm backporting the fix to old old kernels...
and some you know....). Thanks for the review!

Thanks,
Gao Xiang

> 
> --D
> 
> > -- 
> > 2.18.1
> > 
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux