Hi Sero, > openSUSE and SLE don't support username begin with digit, so it will > skip test generic/597 and generic/598 by lack of 123456-fsgqa user. > generic/597 and 598 are not test username begin with digit on purpose > (different with generic/381). It's will be helpful to use an username nit: "It's will": maybe typo, do you mean "it would be"? > begin with non-digit in this case. Reviewed-by: Petr Vorel <pvorel@xxxxxxx> > +++ b/tests/generic/597 > @@ -41,13 +41,11 @@ _supported_os Linux > _require_test > _require_sysctl_variable fs.protected_symlinks > _require_sysctl_variable fs.protected_hardlinks > -# su in _require_user prints warnings about user name starts with a digit, > -# discard the warning > -_require_user 123456-fsgqa >/dev/null 2>&1 > +_require_user fsgqa2 > # Do this SECOND so that qa_user is fsgqa, and _user_do uses that account > _require_user fsgqa > -OWNER=123456-fsgqa > +OWNER=fsgqa2 > OTHER=fsgqa BTW fsgqa is default parameter for _require_user, it wouldn't have to be specified on second call, but that's not important, I'd personally reduce duplicity a bit, but up to you (tiny detail, current patch is perfectly ok): * tests/generic/598 USER1=fsgqa2 USER2=fsgqa _require_user $USER1 # Do this SECOND so that qa_user is fsgqa, and _user_do uses that account _require_user $USER2 * tests/generic/597 OWNER=fsgqa2 OTHER=fsgqa _require_user $OWNER # Do this SECOND so that qa_user is fsgqa, and _user_do uses that account _require_user $OTHER Kind regards, Petr
