On Thu, May 28, 2020 at 03:32:59PM +0800, Yang Xu wrote:
> When using old xfsprogs version, xfs_io doesn't support syncfs command.
> It was not fixed until xfsprogs commit eb24bcffc0("xfs_io: fix missing syncfs command").
> Add a require for this so that we can skip this case if xfs_io doesn't
> support syncfs command.
>
> Reported-by: Feiyu Zhu <zhufy.jy@xxxxxxxxxxxxxx>
> Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxxxxx>
> ---
> tests/generic/484 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/484 b/tests/generic/484
> index cf257c6b..dad411e9 100755
> --- a/tests/generic/484
> +++ b/tests/generic/484
> @@ -42,6 +42,7 @@ _require_scratch_nocheck
> # realtime subvolume, thus the test will fail with rtinherit=1
> _require_no_rtinherit
> _require_dm_target error
> +_require_xfs_io_command "syncfs"
That's good to me, as ext4/034 and generic/474 already had this 'requirement'.
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>
Thanks,
Zorro
>
> rm -f $seqres.full
>
> --
> 2.23.0
>
>
>
