On Tue, May 05, 2020 at 03:17:38PM -0500, Eric Sandeen wrote:
> New _require_sysctl test to ensure that the sysctl we wish to test is
> available on the system.
>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
>
> diff --git a/common/rc b/common/rc
> index 2000bd9d..2734dbf6 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -4208,6 +4208,12 @@ _require_bsd_process_accounting()
> $ACCTON_PROG off >> $seqres.full
> }
>
> +_require_sysctl()
IMHO, this name seems a bit confusing, it looks like it requires the
sysctl command itself. How about _require_sysctl_entry ?
> +{
> + name=$1
Declare local var with 'local'.
> + sysctl $name &>/dev/null || _notrun "$name sysctl unavailable"
> +}
And I think this patch could be folded into the first test that takes
use of it, i.e. patch 2.
Thanks,
Eryu
> +
> init_rc
>
> ################################################################################
