On Tue, May 12, 2020 at 09:15:50AM +0300, Nikolay Borisov wrote: > > > On 15.04.20 г. 23:54 ч., Omar Sandoval wrote: > > From: Omar Sandoval <osandov@xxxxxx> > > > > These two tests test direct I/O and buffered read repair, respectively, > > with fail_make_request. However, by using "fail_make_request/times", > > they rely on repair having a specific I/O pattern. My pending Btrfs > > direct I/O refactoring patch series changes this I/O pattern and thus > > breaks this test. > > > > The dm-dust target (added in v5.2) emulates a device with bad blocks > > that are fixed when written to (like a device that remaps bad blocks). > > This is exactly what we want for testing repair. Add some common dm-dust > > helpers and update the tests to use dm-dust. > > > > Signed-off-by: Omar Sandoval <osandov@xxxxxx> > > Eryu, are you going to merge this patch ? The dmdust part seems fine to me, could you or other btrfs folks help review the btrfs change? That'd be appreciated! Thanks, Eryu