On 2020/4/22 下午3:52, Qu Wenruo wrote: > > > On 2020/4/22 下午3:46, Marek Behun wrote: >> On Wed, 22 Apr 2020 14:49:43 +0800 >> Qu Wenruo <wqu@xxxxxxxx> wrote: >> >> Hi Qu, >> >>> The current btrfs code in U-boot is using a creative way to read on-disk >>> data. >>> It's pretty simple, involving the least amount of code, but pretty >>> different from btrfs-progs nor kernel, making it pretty hard to sync >>> code between different projects. >> >> do you think maybe btrfs-progs / kernel would be interested if I >> tried to convert their code to this "simpler to use" implementation of >> conversion functions? > > I don't think so, the problem is kernel and btrfs-progs all need to > modify extent buffer, which make the read time conversion become a > burden in write path. > >> >>> Thus only the following 5 patches need extra review attention: >>> - Patch 0017 >>> - Patch 0018 >>> - Patch 0022 >>> - Patch 0023 >>> - Patch 0024 >> >> Anyway, this patch series does not apply cleanly on u-boot/master. I >> tried with the first 3 patches and then gave up :( >> Sorry about this but I will review and test if you send a series that >> applies cleanly. > > That's strange, the branch is originally based on an older master, as > you can find in the github. > > I guess there are some more btrfs related code change since then, I'll > rebase them to latest master, and update the github repo then. Git repo updated. You can fetch that branch. Only two small conflicts during rebase, and since it compiles I haven't re-done the full test, but it looks pretty OK. Thanks, Qu > > Thanks, > Qu > >> >> Marek >> >
Attachment:
signature.asc
Description: OpenPGP digital signature
