On Tue, Apr 21, 2020 at 01:36:43PM +0200, Anthony Iliopoulos wrote: > Running xfs/126 sometimes fails due to output mismatch. Due to the > randomized nature of the test, periodically the selected bits are not > relevant to the test, or the selected bits are not flipped. Supply an > offset that is close to the start of the metadata block, so that the > test will reliably corrupt the header. > > Suggested-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > Link: https://lore.kernel.org/linux-xfs/20200116160323.GC2149943@magnolia > Signed-off-by: Anthony Iliopoulos <ailiop@xxxxxxxx> Seems fine to me... Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > --- > tests/xfs/126 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/xfs/126 b/tests/xfs/126 > index 4f9f8cf9..d01338c9 100755 > --- a/tests/xfs/126 > +++ b/tests/xfs/126 > @@ -72,7 +72,7 @@ echo "+ corrupt xattr" > loff=1 > while true; do > _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" | grep -q 'file attr block is unmapped' && break > - _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full > + _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" -c "blocktrash -o 4 -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full > loff="$((loff + 1))" > done > > -- > 2.26.2 >
