On 4/9/20 3:48 PM, Darrick J. Wong wrote: > On Thu, Apr 09, 2020 at 02:09:04PM -0500, Eric Sandeen wrote: >> Consistently use _require_symlinks on all generic tests which >> create a symlink. >> >> Rename an old require function, "_require_test_symlinks" to simply > > Wait, we're adding and renaming at the same time? > > One thing per patch, please... meh, purely cosmetic but *shrug* >> "_require_symlinks" because it's reasonable to assume that if the >> test device doesn't support it, neither does the scratch device >> and vice versa. >> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> >> --- >> diff --git a/tests/generic/025 b/tests/generic/025 >> index e69d655f..e0f71375 100755 >> --- a/tests/generic/025 >> +++ b/tests/generic/025 >> @@ -30,7 +30,6 @@ _supported_os Linux >> >> _require_test >> _require_renameat2 exchange >> -_require_test_symlinks > > This drops _require_symlinks, in a add/renaming patch... > > /me confused. whoops. well, yeah, the test doesn't use symlinks but that wasn't supposed to be here. :P
