On Tue, Mar 17, 2020 at 12:23:38PM -0300, Paulo Alcantara wrote: > Zorro Lang <zlang@xxxxxxxxxx> writes: > > > On Mon, Mar 16, 2020 at 10:54:39PM -0300, Paulo Alcantara (SUSE) wrote: > >> The 'grep -c "error"' check was causing false positive results for > >> cifs.ko when running it with 'echo 1 > /proc/fs/cifs/cifsFYI'. > >> > >> That is, the test would fail when cifs.ko prints out a non-error > >> message like this: > >> > >> [ 2320.903987] fs/cifs/smb2maperror.c: Mapping SMB2 status code > >> 0x80000006 to POSIX err -61 > >> > >> Signed-off-by: Paulo Alcantara (SUSE) <pc@xxxxxx> > >> --- > >> tests/generic/310 | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/tests/generic/310 b/tests/generic/310 > >> index 1fcd517e4e6f..504f7c44c177 100755 > >> --- a/tests/generic/310 > >> +++ b/tests/generic/310 > >> @@ -49,7 +49,7 @@ _require_command "$KILLALL_PROG" killall > >> dmesg -c > /dev/null > >> > >> nr_bug=`dmesg | grep -c "kernel BUG"` > >> -nr_error=`dmesg | grep -c "error"` > >> +nr_error=`dmesg | grep -c "EXT[234]-fs error"` > > > > This's a generic test, which is not only for extN filesystem. If only for > > "fs/cifs/smb2maperror.c: Mapping SMB2 status ...", how about: > > grep -wc "error" > > or > > grep -c "\berror" > > > > or something better:) > > > > I think it still works for "EXT3-fs error (device loop1): ext3_readdir: > > bad entry in ....". > > Both look good to me. Thanks for pointing it out! > > Eryu, > > Do you want me to resend or you can just apply one of above suggestions? This change seems easy enough, I can fix it on commit. Thanks! Eryu
