On Sun, Mar 08, 2020 at 11:13:07PM +0800, Eryu Guan wrote: > On Sun, Mar 01, 2020 at 02:06:54PM -0300, Marcos Paulo de Souza wrote: > > On Sun, Mar 01, 2020 at 09:54:06PM +0800, Eryu Guan wrote: > > > On Mon, Feb 24, 2020 at 12:13:41AM -0300, Marcos Paulo de Souza wrote: > > > > From: Marcos Paulo de Souza <mpdesouza@xxxxxxxx> > > > > > > > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx> > > > > > > Looks fine to me overall, but it'd be better to have commit message to > > > describe the test. > > > > > > Also, it'd be great if btrfs folks could help review it. > > > > Indeed, a commit message makes things better. I'm attaching here a new version > > of the patch containing a commit message. This new version also bumps the test > > number from 203 -> 207, since other messages were merged after I sent my patch. > > Thanks! Would you please send a formal patch to the list? > > > > > While adding the commit message I found in Josef's commit that he added a new > > btrfs test 206, but groups contained test 204[1]. Is it a typo? > > Ah, it is, my bad. This is a merge error and easy enough to fix, I've > fixed it in my local tree. Thanks for pointing it out! Then I noticed that Omar has fixed it in his new test.. Will drop my local fix. Eryu
