On Wed, Feb 19, 2020 at 10:23:29PM -0600, Eric Sandeen wrote: > > > On 2/19/20 10:15 PM, Zorro Lang wrote: > > On Wed, Feb 19, 2020 at 08:57:58PM -0600, Eric Sandeen wrote: > >> On 2/16/20 12:16 PM, Zorro Lang wrote: > >>> --- /dev/null > >>> +++ b/tests/generic/593.out > >>> @@ -0,0 +1,32 @@ > >>> +QA output created by 593 > >>> +1. set project quota timer > >>> +*** Report for user quotas on device SCRATCH_DEV > >>> +Block grace time: 7days; Inode grace time: 7days > >>> +*** Report for group quotas on device SCRATCH_DEV > >>> +Block grace time: 7days; Inode grace time: 7days > >>> +*** Report for project quotas on device SCRATCH_DEV > >>> +Block grace time: 00:10; Inode grace time: 00:20 > >> > >> One other thing that might be an issue here, I'm not sure every > >> filesystem will default to 7 days if no other grace period is set ...? > > > > Make sense:) I just hope to test the default grace time by pass. > > How about: > > 1) Get the default quota timer $string. > > 2) Filter above default timer "$string" to "default". > > to avoid defferent default timer breaks the golden output. > > Makes sense to me, at least after I fix the other xfs bugs ;) Yeah, I just reviewed your patch: [PATCH] xfs: test that default grace periods init on first mount I think my case hard to cover this situation, I have to filter the default value, but if the default value is bad from beginning, it can't help :) Thanks, Zorro > > -Eric >
