Re: shared/032: add options for reiser4

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Jan 31, 2020 at 12:55:47PM -0800, Christian Kujau wrote:
> Last night I had xfstests running and after a while it hung at shared/032 
> because I had reiser4progs installed and it was waiting for input:
> 
> -----------------------------------------------------------------
> mkfs -t reiser4 /dev/ram0
> mkfs.reiser4 1.2.1
> Format release: 4.0.2
> Copyright (C) 2001-2005 by Hans Reiser, licensing governed by 
> reiser4progs/COPYING. 
> 
> Block size 4096 will be used.                                                                                                                                                                         
> Linux 5.5.0-rc5-amd64 is detected.                                                                                                                                                                    
> Uuid 2006a590-832a-49f5-9317-cf91bf866dd7 will be used.                                                                                                                                               
> Reiser4 is going to be created on /dev/ram0.                                                                                                                                                          
> (Yes/No): 
> -----------------------------------------------------------------
> 
> The patch below adds an option (cf. reiserfs the line above) so that the 
> test continues.
> 
> Curiously enough the test still "succeeds" for reiser{fs,4} (and jfs too) 
> because the userspace tools don't appear to have a routine to check for 
> "contains an existing filesystem", but that could be addressed in a 
> different patch.
> 
> Signed-off-by: Christian Kujau <lists@xxxxxxxxxxxxxxx>

Thanks for the patch! But This patch cannot be applied, seems the format
is wrong.

But it's easy enough to apply manually, just please make sure the patch
format is correct next time.

Thanks,
Eryu

> 
> --- tests/shared/032.orig	2020-01-12 08:43:34.000000000 -0800
> +++ tests/shared/032	2020-01-31 12:30:27.158763104 -0800
> @@ -49,6 +49,7 @@
>  	[ $fs = gfs ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
>  	[ $fs = gfs2 ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
>  	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
> +	[ $fs = reiser4 ] && preop="echo y |" && preargs="-f"
>  	# cramfs mkfs requires a directory argument
>  	[ $fs = cramfs ] && preargs=/proc/fs
>  	[ $fs = ext2 ] && preargs="-F"
> 
> -- 
> BOFH excuse #164:
> 
> root rot



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux