Re: [PATCH] fstests: btrfs/022: Disable snapshot ioctl in fsstress

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 2/6/20 7:35 PM, Qu Wenruo wrote:


On 2020/2/6 下午11:47, Josef Bacik wrote:
On 2/6/20 12:32 AM, Qu Wenruo wrote:
Since commit fd0830929573 ("fsstress: add the ability to create
snapshots") adds the ability for fsstress to create/delete snapshot and
subvolume, test case btrfs/022 fails as _btrfs_get_subvolid can't
handle multiple subvolumes under the same path.

So manually disable snapshot/subvolume creation and deletion ioctl in
this
test case. Other qgroup test cases aren't affected.

Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>

Why not just fix _btrfs_get_subvolid?  You can use egrep to make sure
the name matches exactly.  Thanks,

Because we have other requirement, like limit tests.

If we have other snapshots/subvolumes, they don't have the same limit,
thus unable to test qgroup properly.


That's fair, but we should also fix _btrfs_get_subvolid since we know it doesn't work in this case. Thanks,

Josef



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux