Re: [PATCH v3 2/2] generic: Add check for required keep_size/punch_hole/zero_range/collapse_range

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Jan 7, 2020 at 10:45 AM Xiao Yang <yangx.jy@xxxxxxxxxxxxxx> wrote:
>
> Tests need the exact operations to reproduce some issues by --replay-ops so skip tests
> rather than one operation if a required operation/flag in tests is not supported.
>
> Signed-off-by: Xiao Yang <yangx.jy@xxxxxxxxxxxxxx>

Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>

Thanks

> ---
>  tests/generic/456 | 3 +++
>  tests/generic/469 | 3 +++
>  tests/generic/499 | 1 +
>  tests/generic/511 | 1 +
>  4 files changed, 8 insertions(+)
>
> diff --git a/tests/generic/456 b/tests/generic/456
> index 6124f0bb..434a0ffa 100755
> --- a/tests/generic/456
> +++ b/tests/generic/456
> @@ -36,6 +36,9 @@ _supported_fs generic
>  _supported_os Linux
>  _require_scratch
>  _require_dm_target flakey
> +_require_xfs_io_command "falloc" "-k"
> +_require_xfs_io_command "fzero"
> +_require_xfs_io_command "fcollapse"
>
>  rm -f $seqres.full
>
> diff --git a/tests/generic/469 b/tests/generic/469
> index 47fdf0cf..e9411d47 100755
> --- a/tests/generic/469
> +++ b/tests/generic/469
> @@ -40,6 +40,9 @@ rm -f $seqres.full
>  _supported_fs generic
>  _supported_os Linux
>  _require_test
> +_require_xfs_io_command "falloc" "-k"
> +_require_xfs_io_command "fpunch"
> +_require_xfs_io_command "fzero"
>
>  run_fsx()
>  {
> diff --git a/tests/generic/499 b/tests/generic/499
> index 773eab2e..b3363ac4 100755
> --- a/tests/generic/499
> +++ b/tests/generic/499
> @@ -28,6 +28,7 @@ _cleanup()
>  _supported_fs generic
>  _supported_os Linux
>  _require_scratch
> +_require_xfs_io_command "falloc" "-k"
>  _require_xfs_io_command "fcollapse"
>  _require_xfs_io_command "fzero"
>
> diff --git a/tests/generic/511 b/tests/generic/511
> index 4d133f49..f8022905 100755
> --- a/tests/generic/511
> +++ b/tests/generic/511
> @@ -28,6 +28,7 @@ _cleanup()
>  _supported_fs generic
>  _supported_os Linux
>  _require_scratch
> +_require_xfs_io_command "falloc" "-k"
>  _require_xfs_io_command "fzero"
>
>  rm -f $seqres.full
> --
> 2.21.0
>
>
>



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux