On 2020/1/3 16:26, Eryu Guan wrote:
I proposed a similar fix back in 2017[1], but Amir didn't like it because my patch (and your patch) ignored keep_size silently (newly generated ops list was different than the one fed to --replay-ops). I proposed a new version in last Oct[2], which will record such ops as skipped in the generated ops list, and Brian suggested to add a switch to control the behavior if we want to fail fsx on unsupported ops. But I didn't have time to work on it since then.. Would you like to help implement the switch Brian suggested based on my second patch? Then I can apply my v2 patch& your switch patch. Thanks! Eryu [1]https://spinics.net/lists/fstests/msg07953.html [2]https://lore.kernel.org/fstests/20191023130934.GD59518@bfoster/
Hi Eryu, Sure, I will try to implement the switch. :-) Thanks for your detailed explanation. Thanks, Xiao Yang