When I test this case on xfs, it may fail as below: -------------------------------------------- === link SCRATCH_MNT/A/foo SCRATCH_MNT/bar with fsync SCRATCH_MNT/A === +umount: /mnt/xfstests/scratch: target is busy. + (In some cases useful info about processes that use + the device is found by lsof(8) or fuser(1)) --------------------------------------------- I think we don't need to sync all fs and fsync SCRATCH_MNT is enough. Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxxxxx> --- tests/generic/520 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generic/520 b/tests/generic/520 index 167d7077..a16467ca 100755 --- a/tests/generic/520 +++ b/tests/generic/520 @@ -58,7 +58,7 @@ clean_dir() { _mount_flakey rm -rf $(find $SCRATCH_MNT/* | grep -v "lost+found") - sync + $XFS_IO_PROG -c "fsync" $SCRATCH_MNT _unmount_flakey } -- 2.18.0