On Wed, Dec 11, 2019 at 03:23:06PM +0800, Anand Jain wrote: > > And I tend to remove the fail_make_request requirement from some tests, > > and direct read with multiple try should be enough to trigger repair for > > test btrfs/142 and btrfs/143. > > > > > In fact, I don't believe your current fix is good enough to handle both > > old and new mkfs.btrfs. > > It was designed to handle only forward compatible. If possible the tests should be robust and check assumptions and also not hardcode eg. fixed block offset values that could change for various reasons. Forward compatibility makes it hard to test backports, not only on enterprise kernels but also on older stable kernels. We're in a state where developers have list of tests to ignore because they known to be bogus or unreliable.
