On Mon, Dec 09, 2019 at 05:14:52PM +0000, Luis Henriques wrote: > Without this check the test will fail with message: > > fallocate: Operation not supported > > Instead, with this _require_xfs_io_command, the test will be skipped > instead if falloc isn't supported. Thanks, I missed this. Reviewed-by: Omar Sandoval <osandov@xxxxxx> > Signed-off-by: Luis Henriques <lhenriques@xxxxxxxx> > --- > tests/generic/590 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/generic/590 b/tests/generic/590 > index 80a665c6b001..2670fe99d21f 100755 > --- a/tests/generic/590 > +++ b/tests/generic/590 > @@ -34,6 +34,7 @@ rm -f $seqres.full > _supported_fs generic > _supported_os Linux > _require_scratch_nocheck > +_require_xfs_io_command "falloc" > > maxextlen=$((0x1fffff)) > bs=4096