On Wed, Nov 13, 2019 at 02:59:38PM +0800, Qu Wenruo wrote: > Currently fstests will remove $seqres.dmesg if nothing wrong happened. > It saves some space, but sometimes it may not provide good enough > history for developers to check. > E.g. some unexpected dmesg from fs, but not serious enough to be caught > by current filter. > > So instead of deleting the ordinary $seqres.dmesg, just keep them, so > we can archive them for later review. > > Signed-off-by: Qu Wenruo <wqu@xxxxxxxx> This looks fine to me, but it causes more disk space consumption and may eat all rootfs space quickly and unexpectedly. I suggest we add an option to control the behavior, and default behavior is to delete the dmesg file. Thanks, Eryu > --- > common/rc | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/common/rc b/common/rc > index b988e912..59a339a6 100644 > --- a/common/rc > +++ b/common/rc > @@ -3625,10 +3625,8 @@ _check_dmesg() > if [ $? -eq 0 ]; then > _dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)" > return 1 > - else > - rm -f $seqres.dmesg > - return 0 > fi > + return 0 > } > > # capture the kmemleak report > -- > 2.23.0 >
