On Wed, Oct 16, 2019 at 07:53:47PM +0900, Misono Tomohiro wrote:
> This test requires fallocate keep_size. So, skip the test if
> a target FS does not support the function to avoid false negative.
>
> Signed-off-by: Misono Tomohiro <misono.tomohiro@xxxxxxxxxxxxxx>
Would you please paste the false failure you've seen? I can't recall I
hit such failures, and I think fsx would just disable unsupported
operations and don't cause failure, it just prints a message to stderr,
and we already redirect stderr to $seqres.full in run_fsx in 469.
Thanks,
Eryu
> ---
> tests/generic/469 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/469 b/tests/generic/469
> index 47fdf0cf..0c6f8ae5 100755
> --- a/tests/generic/469
> +++ b/tests/generic/469
> @@ -40,6 +40,7 @@ rm -f $seqres.full
> _supported_fs generic
> _supported_os Linux
> _require_test
> +_require_xfs_io_command "falloc" "-k"
>
> run_fsx()
> {
> --
> 2.21.0
>
