Re: [PATCH] generic/469: Skip the test if fallocate keep_size is not supported

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]





on 2019/10/17 10:52, Misono, Tomohiro/味曽野 智礼 wrote:
This test requires fallocate keep_size. So, skip the test if a target
FS does not support the function to avoid false negative.

Can you tell me your kernel version and filesystem. IMO this fallocate keep_size feature has been supported since long times ago(xfs
implemented it in 2008 and ext4 in 2007).

Hi,

I'm now testing virtiofs and want to avoid noise. I think NFS 4 does not support fallocate keep_size neither.

Hi

I see. But in generic/499, it also uses fallocate keep size, so I think you can also add _require_xfs_io_command "falloc" "-k" in that case(I guess generic/499 doesn't run on your system).

ps: In generic/469, it can also add fzero check.

Thanks.
Thanks.


Signed-off-by: Misono Tomohiro <misono.tomohiro@xxxxxxxxxxxxxx>
---
   tests/generic/469 | 1 +
   1 file changed, 1 insertion(+)

diff --git a/tests/generic/469 b/tests/generic/469 index
47fdf0cf..0c6f8ae5 100755
--- a/tests/generic/469
+++ b/tests/generic/469
@@ -40,6 +40,7 @@ rm -f $seqres.full
   _supported_fs generic
   _supported_os Linux
   _require_test
+_require_xfs_io_command "falloc" "-k"

   run_fsx()
   {






[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux