On Wed, Sep 25, 2019 at 6:27 AM Zhihao Cheng <chengzhihao1@xxxxxxxxxx> wrote:
>
> There are indeed many '-b' options in xfstests. I only confirmed the line of overlay test. Other -b test options I need to reconfirm later.
>
FWIW, I eyeballed blockdev related overlayfs common code bits
and all I found out of order was:
@@ -3100,7 +3100,7 @@ _require_scratch_shutdown()
# SCRATCH_DEV, in this case OVL_BASE_SCRATCH_DEV
# will be null, so check OVL_BASE_SCRATCH_DEV before
# running shutdown to avoid shutting down base
fs accidently.
- _notrun "$SCRATCH_DEV is not a block device"
+ _notrun "this test requires a valid
\$OVL_BASE_SCRATCH_DEV as ovl base fs"
else
src/godown -f $OVL_BASE_SCRATCH_MNT 2>&1 \
|| _notrun "Underlying filesystem does not
support shutdown"
Zhihaho,
That's all I meant in the nit.
The v1 commit message was perfectly fine, there was no need to change it at all.
Thanks,
Amir.
