[PATCH][xfstests-bld] build-all: fix acl tools build

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On a clean do-all buster image getfacl is dynamically
linked with libacl.so.1, but the built library is not installed.
The installed libacl.so.1 in the image is incompatible with the
version of acl tools that we build:

root@kvm-xfstests:~# getfacl -n -p xfstests/
getfacl: symbol lookup error: getfacl: undefined symbol: walk_tree

Fix this by linking acl tools with the static libacl library.

Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
---
 build-all | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/build-all b/build-all
index 217ae62..83a1394 100755
--- a/build-all
+++ b/build-all
@@ -233,12 +233,15 @@ fi
 
 if test -z "$SKIP_ACL" ; then
     build_start "ACL library"
+    # Specify NO_SOLIB=1 so that libacl is only built as a static
+    # library.  Then acl tools will be statically linked to it, and we won't
+    # have to install libacl1.so.
     (cd acl; \
      CPPFLAGS="-I$DESTDIR/include" \
      CFLAGS="$LCF -I$DESTDIR/include" \
      LDFLAGS="$LLF $EXEC_LDFLAGS -L$DESTDIR/lib" \
      ./configure $cross --prefix=$DESTDIR --disable-nls; $MAKE_CLEAN ; \
-     make $J LDFLAGS="$LLF $EXEC_LLDFLAGS -static -L$DESTDIR/lib" ; \
+     make $J NO_SOLIB=1 LDFLAGS="$LLF $EXEC_LLDFLAGS -static -L$DESTDIR/lib" ; \
      make $J install)
 fi
 
-- 
2.17.1




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux