On Tue, 2019-09-17 at 21:15 -0700, ira.weiny@xxxxxxxxx wrote: > From: Ira Weiny <ira.weiny@xxxxxxxxx> > > Rather than have a separate lease test, combine the previously proposed lease > tests[1] directly to locktest because they share so much code. > > To make things cleaner update the lock test code and test script. This > includes fixing a rather serious bug. > > Finally update the error output to help identify any steps which fail during > testing. > > Ira > > [1] https://www.spinics.net/lists/fstests/msg12467.html > > Ira Weiny (13): > src/locktest: Remove unnecessary sleep > src/locktest: Remove OPEN macro > src/locktest: Change command macro names > src/locktest: Add get_cmd_str > src/locktest.c: Clean up client command passing > src/locktest.c: Fix return code if last test fails > generic/131: Clean up pid variables > generic/131: Save stderr for debugging > src/locktest: Add simple lease testing > src/locktest: Add lease testing for basic signal reception > src/locktest: Add truncate lease tests > src/locktest: Clean up error output > src/locktest: Audit all debug output > > src/locktest.c | 957 ++++++++++++++++++++++++++++++---------------- > tests/generic/131 | 72 ++-- > 2 files changed, 666 insertions(+), 363 deletions(-) > Nice work, Ira. This all looks like good cleanup (and at least one important bugfix). Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
