On Thu, Aug 15, 2019 at 08:24:25AM -0700, Darrick J. Wong wrote: > On Thu, Aug 15, 2019 at 11:00:31AM -0400, Josef Bacik wrote: > > I recently fixed some bugs in btrfs's enospc handling that made it start > > failing generic/500. > > > > The point of this test is to make the thin provisioned device run out of > > space, which results in an EIO being seen on a device from the file > > systems perspective. This is fine for xfs and ext4 who's metadata is > > being overwritten and already allocated on the thin provisioned device. > > They get an EIO on data writes, fstrim to free up the space, and keep it > > going. > > > > Btrfs however has dynamic metadata, so the rm -rf could result in > > metadata IO being done on the file system. Since the thin provisioned > > device is out of space this gives us an EIO, and we flip read only. We > > didn't remove the file, so the fstrim doesn't recover space anyway, so > > we can't even fstrim and remount. > > > > Make this test for ext4/xfs only, it just simply won't work right for > > btrfs in it's current form. > > How about: > > test $FSTYP = "btrfs" && _notrun "btrfs doesn't work that way lol" > > since afaik btrfs is the only fs that shouldn't run this test? > Also, I think Ted was trying to kill off tests/shared/... > That explains why it seemed emptier than normal. Yeah that sounds like a fine solution to me, I'll send a updated patch shortly. Thanks, Josef
