, On Wed, Jul 10, 2019 at 4:04 PM Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx> wrote: > > Mauricio Faria de Oliveira <mfo@xxxxxxxxxxxxx> writes: > > > The kernel version (uname -v) may also be needed in addition to > > the kernel release (uname -r) in order to properly identify and > > distinguish different kernel builds in some cases/distributions. > > > > For example, in the Ubuntu kernel package the test/debug string > > is usually a suffix to the version field, not the release field. > > > > $ uname -rv > > 4.15.0-51-generic #55-Ubuntu SMP Wed May 15 14:27:21 UTC 2019 > > > > $ uname -rv > > 4.15.0-51-generic #55+test20190520b1 SMP Mon May 20 11:57:40 -03 2019 > > > > Looking at other OSes uname(1) man pages it looks like '-v' is > > quite standard, and the Linux man page only cites '-p' and '-i' > > as non-portable, so the change should be OK. The only caller is > > the 'check' script for the header print out, so it's contained. > > > > I'm just considering that -v also prints more clutter like the kernel > build date. Do you need it? It seems off for the PLATFORM line, > which has stuff not kernel related. Can you trim the output a > bit to remove it? > It indeed prints out some clutter that's usually not required, but it's hard to tell which parts of it may (not) be useful in general for particular/different users, to consider trimming it, so the complete string seemed to be the way go IMO. > Anyway, > > Reviewed-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx> Thanks for reviewing. > > -- > Gabriel Krisman Bertazi cheers, -- Mauricio Faria de Oliveira
