On Fri, Jun 28, 2019 at 05:40:30PM +0800, Eryu Guan wrote: > > > > shared/001 --> ext4/036 > > shared/003 --> ext4/037 > > shared/004 --> ext4/038 > > shared/272 --> ext4/039 > > Looks like shared/001 and shared/004 are not journal related and could > run with ext2 as well. So the two tests should be part of patch 3? Orphaned inodes is something which is only a thing with ext3/ext4. The fact that these tests pass on ext2 is purely a happy accident --- because ext2 completely ignores the orphaned list. I suppose I should just remove ext2 from the supported list, but these tests take a super small amount of time so why the tests are kinda pointless for ext2, it doesn't cost much time, either. > And I guess we should update "_supported_fs" field in ext4/037 and > ext4/039 too, so they only support ext4. ext4/037 should have be marked as only supported by ext3 and ext4. It's passing by accident on my system because I have CONFIG_EXT4_USE_FOR_EXT2, and so the lack of the noload mount option wasn't tripping up the test and causing a test failure. (The fact that no one has complained is actually a really strong suggestion that most people running xfstests have EXT4_USE_FOR_EXT2 enabled.) I'll fix this. ext4/039 is right as is; it makes sense for ext3 and ext4, and if someone is testing with FSTYP=ext3 we do want to run that test. I'll adjust some of the supported_fs lines in the next version. - Ted
