On Fri, Jun 21, 2019 at 11:48:57AM +0100, Filipe Manana wrote: > On Fri, Jun 21, 2019 at 11:36 AM Eryu Guan <guaneryu@xxxxxxxxx> wrote: > > > > On Wed, Jun 19, 2019 at 01:06:24PM +0100, fdmanana@xxxxxxxxxx wrote: > > > From: Filipe Manana <fdmanana@xxxxxxxx> > > > > > > Test as well that hole punch operations that affect a single file block > > > also update the file's mtime and ctime. > > > > > > This is motivated by a bug a found in btrfs which is fixed by the > > > following patch for the linux kernel: > > > > > > "Btrfs: add missing inode version, ctime and mtime updates when > > > punching hole" > > > > > > Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx> > > > --- > > > tests/generic/059 | 18 ++++++++++++++++++ > > > 1 file changed, 18 insertions(+) > > > > > > diff --git a/tests/generic/059 b/tests/generic/059 > > > index e8cb93d8..fd44b2ea 100755 > > > --- a/tests/generic/059 > > > +++ b/tests/generic/059 > > > @@ -18,6 +18,9 @@ > > > # > > > # Btrfs: add missing inode update when punching hole > > > # > > > +# Also test the mtime and ctime properties of the file change after punching > > > +# holes with ranges that operate only on a single block of the file. > > > +# > > > seq=`basename $0` > > > seqres=$RESULT_DIR/$seq > > > echo "QA output created by $seq" > > > @@ -68,6 +71,13 @@ $XFS_IO_PROG -c "fsync" $SCRATCH_MNT/foo > > > # fsync log. > > > sync > > > > > > +# Sleep for 1 second, because we want to check that the next punch operations we > > > +# do update the file's mtime and ctime. > > > +sleep 1 > > > > Is this supposed to be after recording the initial c/mtime? i.e. moving > > it after c/mtime_before? > > Either way is fine. Capturing the times right before or right after > the sleep, gives the same values as nothing changed the file. Ah, you're right. > > Btw, I had noticed the other day that the second "echo" has > $mtime_after instead of $ctime_after (copy-paste mistake). > Do you want me to send a v2 fixing that typo, or you can do it > yourself when you pick the patch? I can fix it on commit, thanks for pointing it out! Thanks, Eryu
