On Sun, Jun 02, 2019 at 03:41:08PM +0300, Amir Goldstein wrote: > Eryu, > > This is a re-work of Dave Chinner's copy_file_range() tests which > I used to verify the kernel fixes of the syscall [1]. > > The 2 first tests fix bugs in the interface, so they are appropriate > for merge IMO. > > The cross-device copy test checks a new functionality, so you may > want to wait with merging it till after the work is merged upstream. > > The bounds check test depend on a change that was only posted to > xfsprogs [2]. Without two changes that were merge to xfsprogs v4.20, > the original test (v1, v2) would hang. Requiring the new copy_range > flag (copy_range -f) mitigates this problem. > > You may want to wait until the xfs_io change is merged before merging > the check for the new flag. Thanks a lot for the detailed explanation! I applied the first three patches for this week's update. Thanks, Eryu > > Thanks, > Amir. > > [1] https://lore.kernel.org/linux-fsdevel/20190531164701.15112-1-amir73il@xxxxxxxxx/ > [2] https://marc.info/?l=linux-xfs&m=155912482124038&w=2 > > Changes from v2: > - Change blockdev in test to loop and _require_loop (Olga) > - Implement and use _require_xfs_io_command copy_range -f > > Changes from v1: > - Remove patch to test EINVAL behavior instead of short copy > - Remove 'chmod -r' permission drop test case > - Split out test for swap/immutable file copy > - Split of cross-device copy test > > > Amir Goldstein (6): > generic: create copy_range group > generic: copy_file_range immutable file test > generic: copy_file_range swapfile test > common/rc: check support for xfs_io copy_range -f N > generic: copy_file_range bounds test > generic: cross-device copy_file_range test > > common/rc | 9 ++- > tests/generic/434 | 2 + > tests/generic/988 | 59 +++++++++++++++++++ > tests/generic/988.out | 5 ++ > tests/generic/989 | 56 ++++++++++++++++++ > tests/generic/989.out | 4 ++ > tests/generic/990 | 132 ++++++++++++++++++++++++++++++++++++++++++ > tests/generic/990.out | 37 ++++++++++++ > tests/generic/991 | 56 ++++++++++++++++++ > tests/generic/991.out | 4 ++ > tests/generic/group | 14 +++-- > 11 files changed, 372 insertions(+), 6 deletions(-) > create mode 100755 tests/generic/988 > create mode 100644 tests/generic/988.out > create mode 100755 tests/generic/989 > create mode 100644 tests/generic/989.out > create mode 100755 tests/generic/990 > create mode 100644 tests/generic/990.out > create mode 100755 tests/generic/991 > create mode 100644 tests/generic/991.out > > -- > 2.17.1 >
