On Thu 30-05-19 17:27:18, Yang Xu wrote: > This adds a regression test for online resizing maximum blocks > which can trigger a BUG_ON with non-zero s_first_data_block > filesystem. > > The bug was fixed by patch: > "ext4: fix crash during online resizing" > > The bug was introduced by patch: > "ext4: convert file system to meta_bg if needed..." > > Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxxxxx> Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Just one nit below: > +# success, all done > +echo "Silence is golden" The "Silence is golden" message doesn't really make sense when the test actually outputs something ;) Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
