Re: [PATCH 1/2] generic/319: use numeric user and group IDs in getfacl

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, May 17, 2019 at 12:49 PM Luis Henriques <lhenriques@xxxxxxxx> wrote:
>
> This prevents test failures if cases where, e.g., /etc/group doesn't
> include the 'root' group ID.
>
> Cc: Filipe Manana <fdmanana@xxxxxxxx>
> Signed-off-by: Luis Henriques <lhenriques@xxxxxxxx>

Reviewed-by: Filipe Manana <fdmanana@xxxxxxxx>

Looks good, thanks.

> ---
>  tests/generic/319     | 4 ++--
>  tests/generic/319.out | 8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tests/generic/319 b/tests/generic/319
> index 02973d90cbe2..504cf627537b 100755
> --- a/tests/generic/319
> +++ b/tests/generic/319
> @@ -44,10 +44,10 @@ _scratch_mount
>
>  mkdir $SCRATCH_MNT/testdir
>  setfacl -d --set u::rwx,g::rwx,o::- $SCRATCH_MNT/testdir
> -getfacl --absolute-names $SCRATCH_MNT/testdir | _filter_scratch
> +getfacl -n --absolute-names $SCRATCH_MNT/testdir | _filter_scratch
>
>  mkdir $SCRATCH_MNT/testdir/testsubdir
> -getfacl --absolute-names $SCRATCH_MNT/testdir/testsubdir | _filter_scratch
> +getfacl -n --absolute-names $SCRATCH_MNT/testdir/testsubdir | _filter_scratch
>
>  # success, all done
>  status=0
> diff --git a/tests/generic/319.out b/tests/generic/319.out
> index b090bfaf6a04..bf6b4bc80462 100644
> --- a/tests/generic/319.out
> +++ b/tests/generic/319.out
> @@ -1,7 +1,7 @@
>  QA output created by 319
>  # file: SCRATCH_MNT/testdir
> -# owner: root
> -# group: root
> +# owner: 0
> +# group: 0
>  user::rwx
>  group::r-x
>  other::r-x
> @@ -10,8 +10,8 @@ default:group::rwx
>  default:other::---
>
>  # file: SCRATCH_MNT/testdir/testsubdir
> -# owner: root
> -# group: root
> +# owner: 0
> +# group: 0
>  user::rwx
>  group::rwx
>  other::---



-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux