On Thu, Apr 25, 2019 at 08:50:30AM -0700, Darrick J. Wong wrote: > On Thu, Apr 25, 2019 at 03:30:27PM +0800, Eryu Guan wrote: > > On Mon, Apr 22, 2019 at 08:48:20AM -0700, Darrick J. Wong wrote: > > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > > > Remove the typedef usage for the xfs geometry structure. > > > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > I guess this is due to patch "xfs: bump XFS_IOC_FSGEOMETRY to v5 > > structures" which removes the xfs_fsop_geom_t typedef? And I'm wondering > > if xfs/122 needs update too? as xfs/122.out contains an xfs_fsop_geom_t > > entry as well. > > xfs/122 does need an update for the new 5.2 ioctls, so yes, I'll send > that one along once they've landed upstream. > > In the meantime, the xfs_fsop_geom_t -> struct xfs_fsop_geom conversion > ought to be applied since the struct FOO approach has always worked. Ok, thanks! Eryu