Re: [PATCH] generic/294: skip on NFS

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Apr 15, 2019 at 12:03:09PM +0800, Eryu Guan wrote:
> On Mon, Mar 04, 2019 at 10:50:08AM +0800, Xiong Zhou wrote:
> > Because NFS handles this differently, returning different values.
> > Details:
> > http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
> > 
> > Signed-off-by: Murphy Zhou <xzhou@xxxxxxxxxx>
> 
> Sorry for the so long delay.. 

Not at all, :)

Sending v2.

Thanks,
Xiong 

> > ---
> >  tests/generic/294 | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/generic/294 b/tests/generic/294
> > index b74579ac..f7e763a3 100755
> > --- a/tests/generic/294
> > +++ b/tests/generic/294
> > @@ -27,6 +27,7 @@ _cleanup()
> >  . ./common/filter
> >  
> >  # real QA test starts here
> > +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
> 
> I think it's better to filter the output of NFS to follow the golden
> output, so when NFS changes behavior, filter fails and we could know
> that from test failure.
> 
> Thanks,
> Eryu
> 
> >  
> >  # Modify as appropriate.
> >  _supported_fs generic
> > -- 
> > 2.21.0
> > 



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux