And 306 also works with cifs (as long as mounting with "sfu" mount option) with this patch On Mon, Apr 1, 2019 at 10:29 AM Steve French <smfrench@xxxxxxxxx> wrote: > > I also verified that test 452 now works to cifs (SMB3 mounts to > multiple types of test targets, Azure, Windows etc.) > > On Sun, Mar 31, 2019 at 7:31 AM XiaoLi Feng <xifeng@xxxxxxxxxx> wrote: > > > > From: Xiaoli Feng <xifeng@xxxxxxxxxx> > > > > When call _scratch_remount for cifs , it always requires to input > > password. This will make generic/306 generic/452 failed because > > cifs remount failed. > > --- > > common/rc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/common/rc b/common/rc > > index 1c42515f..ea1eaf6a 100644 > > --- a/common/rc > > +++ b/common/rc > > @@ -357,7 +357,7 @@ _scratch_remount() > > local opts="$1" > > > > if test -n "$opts"; then > > - mount -o "remount,$opts" $SCRATCH_MNT > > + mount $MOUNT_OPTIONS -o "remount,$opts" $SCRATCH_MNT > > fi > > } > > > > -- > > 2.18.1 > > > > > -- > Thanks, > > Steve -- Thanks, Steve
