On Wed, Feb 20, 2019 at 03:09:32PM +0100, Holger Hoffstätte wrote: > > On Wed, 20 Feb 2019, David Sterba wrote: > > > On Wed, Feb 13, 2019 at 12:48:14PM -0800, Darrick J. Wong wrote: > > > +#include <attr/xattr.h> > > > > This does not compile on some systems, sys/xattr.h works (it's provided > > by glibc) and is also used by other fstests' sources. I'm not sure where > > does attr/xattr.h come from, my devel package for libattr provides only > > attr/libattr.h. > > This was removed from attr back in 2015 [1] but apparently caused > many aplications to no longer compile, so some packagers added attr/xattr.h > back, completing the cycle of confusion. > I just randomly remembered because Gentoo fell into the same sinkhole > and is still climbing out [2]. > > AFAIK sys/xattr.h is the preferred thing now unless you are building on an > ancient distro. ...an ancient distro like Debian Testing or Ubuntu 18.04, which still ships libattr 2.4.47, which has manpages telling you to use attr/xattr.h. OTOH xfsprogs has been using sys/xattr.h since 2009, so patch coming soon. --D > cheers > Holger > > [1] http://git.savannah.nongnu.org/cgit/attr.git/commit/?id=7921157890d07858d092f4003ca4c6bae9fd2c38 > [2] https://bugs.gentoo.org/648864
