Re: [PATCH] Fix error message when xfs handle library not found

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 2/12/19 12:18 PM, fdmanana@xxxxxxxxxx wrote:
> From: Filipe Manana <fdmanana@xxxxxxxx>
> 
> The error message mentions a "make install-lib" target from xfsprogs,
> however that target does not exists in xfsprogs, what exists is a
> target named "install-dev". So fix that and replace "install-lib" with
> "install-dev".
> 
> Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx>
> ---
>  m4/package_xfslibs.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/package_xfslibs.m4 b/m4/package_xfslibs.m4
> index 9be56e11..ad019518 100644
> --- a/m4/package_xfslibs.m4
> +++ b/m4/package_xfslibs.m4
> @@ -83,7 +83,7 @@ AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE],
>          echo
>          echo 'FATAL ERROR: could not find a current XFS handle library.'
>          echo 'Install or upgrade the XFS library package.'

To fix things up a bit more, I'd probably not refer to the "XFS library package"
because I'm not sure that exists anywhere either, does it?

In fedora/rhel land, it's in xfsprogs & xfsprogs-devel for development.

Not sure about suse or debian or ...?

Not a huge deal but if nobody ships xfsprogs-libs (or similar) then maybe best
to fix that line as well.

> -        echo 'Alternatively, run "make install-lib" from the xfsprogs source.'
> +        echo 'Alternatively, run "make install-dev" from the xfsprogs source.'

and yeah, this part makes sense.

-Eric

>          exit 1
>      ])
>      libhdl="-lhandle"
> 



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux