On Wed, Jan 09, 2019 at 10:14:59PM -0500, Cui Yue wrote: > When running xfstests generic/423 to test system call statx() on hard link files of NFS, it fails. > error message: > [!] attr 'stx_mask' differs from ref file, 7ff != e0 > > The values of parameter "mask" between the original file and the reference file are different. > One is STATX_ALL; > The other is STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME. > > Modify the function get_reference() to pass the "mask" in, > and change STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME to "mask". Thanks for the fix! Patch looks fine to me, but please follow the kernel rules for submitting patches in the future. The commit log has too long lines and you're missing Signed-off-by tag. I'll do the update at commit time, no need to resend. Thanks, Eryu
