On Mon, Sep 17, 2018 at 7:56 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > On Mon, Sep 17, 2018 at 12:55 AM Richard Weinberger <richard@xxxxxx> wrote: > > > > On UBIFS we had an embarrassing bug where xattr operations > > worked only for files with nlink > 0. > > Make sure this will never happen again. > > > > Signed-off-by: Richard Weinberger <richard@xxxxxx> > > --- > > Hi! > > > > I'm not sure whether this is worth a new test, maybe we can add it > > to an existing test? What about generic/020? > > We usually add new tests, so existing test wont start failing > for unpatched kernels. > > > Since xfs_io does not support xattrs, we need a new C test helper.t > > > I could just as well write: > > Since xfs_io does not support xattrs, we need to add xattrs support to xfs_io > > but I won't be the one to insist on that. > > What you did is you cloned attr_replace_test.c with the tiniest change > and did not even bother to mention that. > > Please add -T flag support to attr_replace_test.c (following xfs_io -T) > instead of cloning the helper and use that in your new test. > Yet simpler, if you don't really need an O_TMPFILE, you don't need a C helper: exec 5>x rm x setfattr -n user.test -v 1 /proc/self/fd/5 exec 5>&- Thanks, Amir.
