[PATCH] generic/504: Check inode number accurately

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



If inode number is equal to the line number of locks which is
first column in /proc/locks, generic/504 will match wrong number
and get PASS. For example:
-----------------------------------------------------------
inode 12
...
12: FLOCK  ADVISORY  WRITE 1615 00:2e:37889 0 EOF
-----------------------------------------------------------

We should match correct inode number by six column in /proc/locks.

Signed-off-by: Xiao Yang <yangx.jy@xxxxxxxxxxxxxx>
---
 tests/generic/504 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/504 b/tests/generic/504
index c7d015d..21d8605 100755
--- a/tests/generic/504
+++ b/tests/generic/504
@@ -51,7 +51,7 @@ flock -x 9
 cat /proc/locks >> $seqres.full
 
 # Checking
-grep -qw $tf_inode /proc/locks || echo "lock info not found"
+grep -q ":$tf_inode " /proc/locks || echo "lock info not found"
 
 # success, all done
 status=0
-- 
1.8.3.1






[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux