[PATCH] open_by_handle: fix name of directory in error messages

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



dirname() modifies the string in dname, but we use that string
in error messages later on to print the test dir name.
Make another copy of test_dir for passing to dirname().

Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
---
 src/open_by_handle.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/open_by_handle.c b/src/open_by_handle.c
index 36f2b07..4fdfacd 100644
--- a/src/open_by_handle.c
+++ b/src/open_by_handle.c
@@ -123,6 +123,7 @@ int main(int argc, char **argv)
 	int	fd;
 	int	ret = 0;
 	int	failed = 0;
+	char	mname[PATH_MAX];
 	char	dname[PATH_MAX];
 	char	fname[PATH_MAX];
 	char	fname2[PATH_MAX];
@@ -240,9 +241,10 @@ int main(int argc, char **argv)
 	 *    the dentry cache and the use of -ip flag combination would not
 	 *    allow testing decode of dir file handle in cold dcache scenario.
 	 */
+	strcpy(dname, test_dir);
 	if (parent && !in_fd) {
-		strcpy(dname, test_dir);
-		mount_dir = dirname(dname);
+		strcpy(mname, test_dir);
+		mount_dir = dirname(mname);
 		if (create)
 			ret = mkdir(test_dir, 0700);
 		if (ret < 0 && errno != EEXIST) {
-- 
2.7.4




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux