Re: [PATCH] xfstests: generic/062: Change output of empty attribute values

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Aug 22, 2018 at 04:32:01PM +0800, Su Yue wrote:
> Since v2.4.47 of attr(5)[1], commit 0550d2bc989d (Properly
> set and report empty attribute values) changed output format of
> empty attribute value with quotes.
> 
> Here, change generic/062.out to match the actual output.
> 
> [1]: https://git.savannah.nongnu.org/git/attr.git
> 
> Signed-off-by: Su Yue <suy.fnst@xxxxxxxxxxxxxx>
> ---
>  tests/generic/062.out | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/tests/generic/062.out b/tests/generic/062.out
> index 8cc3c655..9b9cd744 100644
> --- a/tests/generic/062.out
> +++ b/tests/generic/062.out
> @@ -13,7 +13,7 @@ SCRATCH_MNT/reg
>  
>  *** set/get one initially empty attribute
>  # file: SCRATCH_MNT/reg
> -user.name
> +user.name=""

This breaks tests with old attr version, we should filter the output so
that both old and new attr could pass the test.

Please see the discussions in this thread.

https://patchwork.kernel.org/patch/10521875/

Thanks,
Eryu



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux