When getfattr dumps values of all extended attributes (-d option),
it doesn't print empty extended attributes. e.g: user.name. But
from attr-2.4.48 this behavior is changed, new getfattr prints
user.name="".
The {=""} will break the golden image, so filter the redundant =""
at the end if it has.
Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx>
---
Hi,
This's a bad news. Latest attr package attr-2.4.48 changed his
behavior as above. And this's different with attr-2.4.47.
With old attr:
# setfattr -h -n user.name testfile
# getfattr -d -n user.name testfile
# file: testfile
user.name
With new attr:
# setfattr -h -n user.name testfile
# getfattr -d -n user.name testfile
# file: testfile
user.name=""
Note: -d option is necessary
This little difference will break golden image. So this's the problem.
If you have better idea than this patch, please tell me.
Thanks,
Zorro
tests/generic/062 | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/generic/062 b/tests/generic/062
index df67960d..4fc2dc46 100755
--- a/tests/generic/062
+++ b/tests/generic/062
@@ -29,9 +29,13 @@ _cleanup()
}
trap "_cleanup; exit \$status" 0 1 2 3 15
+# When getfattr dump values of all extended attributes, it print empty attr
+# as user.name before, but new getfattr print it as user.name="". For match
+# the golden image, filter the redundant ="" at the end.
getfattr()
{
- $GETFATTR_PROG --absolute-names -dh $@ 2>&1 | _filter_scratch
+ $GETFATTR_PROG --absolute-names -dh $@ 2>&1 | _filter_scratch | \
+ sed -e 's/=\"\"//'
}
setfattr()
--
2.14.4
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
