On some old kernel which supports COLLAPSE_RANGE and ZERO_RANGE, but doesn't support INSERT_RANGE, this case alway fails as: QA output created by 499 +main: filesystem does not support fallocate mode FALLOC_FL_INSERT_RANGE, disabling! Silence is golden fsx print one more line to break the golden image. Due to this case don't need to do INSERT_RANGE operations, so use -I options to prevent fsx from probing INSERT_RANGE call. Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx> --- Hi, 1) I think using -I option of fsx is better than _notrun when find the system doesn't support INSERT_RANGE. 2) Although PUCH_HOLE isn't needed either, when a system supports COLLAPSE_RANGE and ZERO_RANGE, it supports PUCH_HOLE too. So I don't use -H option. Thanks, Zorro tests/generic/499 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generic/499 b/tests/generic/499 index 99d6d308..a2eac6ab 100755 --- a/tests/generic/499 +++ b/tests/generic/499 @@ -50,7 +50,7 @@ ENDL victim=$SCRATCH_MNT/a touch $victim -$here/ltp/fsx --replay-ops $tmp.fsxops $victim > $tmp.output || cat $tmp.output +$here/ltp/fsx -I --replay-ops $tmp.fsxops $victim > $tmp.output || cat $tmp.output echo "Silence is golden" status=0 -- 2.14.4 -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
