Re: [PATCH ] xfs/262: remove -y parameter

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



Lu Fengqi <curiouslfq@xxxxxxxxx> 于2018年7月5日周四 下午2:05写道:
>
> Eryu Guan <guaneryu@xxxxxxxxx> 于2018年7月5日周四 下午1:50写道:
> >
> > On Wed, Jul 04, 2018 at 09:02:12PM -0700, Darrick J. Wong wrote:
> > > On Thu, Jul 05, 2018 at 09:37:03AM +0800, Liu Yiding wrote:
> > > > Since commit 66f7b4c2ce14 ("xfs_scrub: remove -y parameter") has removed parameter -y, -y is an invalid option.
> >
> > But I couldn't find this commit in xfsprogs repo
> > git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
> >
> > Is it already upstream?
>
> This commit seems in xfstest-dev.
>

BTW, removing -y option from xfs_scrub is commit 1658224d2b5d
("xfs_scrub: remove preen mode").

-------------------------------------------------------------
Thanks,
Lu

> -------------------------------------------------------------
> Thanks,
> Lu
>
> >
> > > >
> > > > Signed-off-by: Liu Yiding <liuyd.fnst@xxxxxxxxxxxxxx>
> > >
> > > Good catch!
> > >
> > > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> >
> > Thanks for the review!
> >
> > Eryu
> >
> > >
> > > --D
> > >
> > > > ---
> > > >  tests/xfs/262 | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/tests/xfs/262 b/tests/xfs/262
> > > > index 6c39268..b109f93 100755
> > > > --- a/tests/xfs/262
> > > > +++ b/tests/xfs/262
> > > > @@ -48,7 +48,7 @@ done
> > > >  LD_LIBRARY_PATH=$SCRATCH_MNT $LDD_PROG $SCRATCH_MNT/xfs_scrub >> $seqres.full
> > > >
> > > >  echo "Force online repairs"
> > > > -XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTvy $SCRATCH_MNT >> $seqres.full
> > > > +XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTv $SCRATCH_MNT >> $seqres.full
> > > >
> > > >  # success, all done
> > > >  status=0
> > > > --
> > > > 2.7.4
> > > >
> > > >
> > > >
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > > > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux