On Thu, Jun 28, 2018 at 1:07 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Wed, Jun 27, 2018 at 05:43:06PM +0300, Amir Goldstein wrote: >> On Wed, Jun 27, 2018 at 5:27 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: >> > On Wed, Jun 27, 2018 at 01:56:29PM +0300, Amir Goldstein wrote: >> >> On Wed, Jun 27, 2018 at 11:20 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: >> > Because the test is creating image files in $tmp, and we've had >> > problems in the past with tests running the root filesystems out of >> > space because they put too much shit in /tmp or dump crap in $here. >> > TEST_DIR is supposed to be used at the work dir for things like this >> > - we're trying to exercises the filesystem we are testing, not the >> > root filesystem that hosts the fstests installation. >> > >> >> I see. It might be better though to make this fix in a separate patch >> and keeping the conversion patch to the minimal change I suggested. > > We can't make the conversion patch as you suggested because it's > /doesn't fix the broken usage of $tmp/. That's the intent of this > whole conversion - to fix these bugs by converting to common setup > code. So we need to fix the bugs as we convert them, not slap a > band-aid over them and then have to come back and fix them later (if > we remember which of the many, many tests need fixing!). > > Again, lets not ake this conversion harder than it needs to be by > trying to split hairs over how individual bugs are fixed. There are > /hundreds of bugs/ that need to be fixed during this conversion > - the cost of separating them out is prohibitive, and it makes no > sense to add more change management time and overhead to an > already resource intensive conversion process. > No worries. I'll stick to validating correctness in review. I realize how agonizing this conversion task can be. Cheers, Amir. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
