On Sun 03-06-18 22:21:17, Eryu Guan wrote: > On Tue, May 29, 2018 at 06:51:18PM +0200, Jan Kara wrote: > > - export MKFS_XFS_PROG="`set_prog_path mkfs.xfs`" > > - export MKFS_EXT4_PROG="`set_prog_path mkfs.ext4`" > > - export MKFS_UDF_PROG="`set_prog_path mkudffs`" > > - export MKFS_BTRFS_PROG="`set_mkfs_prog_path_with_opts btrfs`" > > - export MKFS_F2FS_PROG="`set_mkfs_prog_path_with_opts f2fs`" > > We should keep above two setups, set_mkfs_prog_path_with_opts does extra > work than set_prog_path. > > > diff --git a/tests/xfs/446 b/tests/xfs/446 > > index 752c6a7de827..ac74723f471f 100755 > > --- a/tests/xfs/446 > > +++ b/tests/xfs/446 > > @@ -37,7 +37,6 @@ trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15 > > # real QA test starts here > > _supported_fs xfs > > _supported_os Linux > > -export CHECKBASHISMS_PROG="`set_prog_path checkbashisms`" > > This is removed but not added in common/config file. > > I fixed both issues on commit. Good spottings. Thanks for fixing them up! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
