On Tue, May 22, 2018 at 08:32:52AM +1000, Dave Chinner wrote:
> On Fri, May 11, 2018 at 11:05:59AM +0800, Eryu Guan wrote:
> > One of _scratch_mkfs_xfs_opts()'s job is to remove any metadata
> > related mkfs options if mkfs.xfs binary doesn't support them, so
> > that tests that pass metadata mkfs options to _scratch_mkfs, e.g.
> > "_scratch_mkfs -m crc=0" won't break with old mkfs.xfs.
> >
> > But commit 596a068bf130 ("fstests: teach _scratch_mkfs to handle
> > mkfs option conflicts") broke this, because it didn't pass any mkfs
> > options to _scratch_mkfs_xfs_opts(). So fix it.
> >
> > Also declare a variable as 'local' and fix a typo.
> >
> > Reported-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > Signed-off-by: Eryu Guan <guaneryu@xxxxxxxxx>
>
> Looks fine.
>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
>
> (sorry for missing this when you opsted it first time)
Thanks for the review!
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
