On 2018/05/17 11:16, Eryu Guan wrote:
On Thu, May 17, 2018 at 09:36:10AM +0800, Xiao Yang wrote:1) Without the fix, perror() can indicate the actual error(ENODATA). 2) After calling perror() and redirecting the output of perror() to a file, errno seems to be set to EINVAL unexpectedly. See the following mail for detailed info: https://www.spinics.net/lists/fstests/msg09675.html Signed-off-by: Xiao Yang<yangx.jy@xxxxxxxxxxxxxx> --- src/attr_replace_test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/attr_replace_test.c b/src/attr_replace_test.c index 23adc07..33fa74d 100644 --- a/src/attr_replace_test.c +++ b/src/attr_replace_test.c @@ -11,7 +11,6 @@ #include<sys/stat.h> #define die() do { perror(""); \ -fprintf(stderr, "error=%d at line %d\n", errno, __LINE__); \We can remove the error number in fprintf, but I think the line number info is still useful (at least it helped me when I was reviewing the test).
Hi Eryu, OK, we just remove errno in fprintf() as below: fprintf(stderr, "error at line %d\n", __LINE__); Thanks, Xiao Yang
Thanks, Eryuexit(1); } while (0) #define fail(...) do { \ -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
-- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
